NGA-TRAN commented on code in PR #16858:
URL: https://github.com/apache/datafusion/pull/16858#discussion_r2225941942
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -368,7 +368,12 @@ pub fn parse_physical_expr(
e.name.as_str(),
scalar_fun_def,
args,
- Field::new("f", convert_required!(e.return_type)?,
true).into(),
+ Field::new(
+ &e.return_field_name,
+ convert_required!(e.return_type)?,
+ true,
Review Comment:
The change here is to use `e.return_field_name` in deserialization. So
whatever name of the UDF we serialize at line 356 of the file `to_proto.rs in`
this PR, it will be deserialized here; and it will match. Does this answer
your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
