NGA-TRAN commented on code in PR #16858:
URL: https://github.com/apache/datafusion/pull/16858#discussion_r2223808490
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1358,6 +1358,9 @@ impl DefaultPhysicalPlanner {
physical_name(expr),
))?])),
}
+ } else if group_expr.is_empty() {
+ // No GROUP BY clause - create empty PhysicalGroupBy
+ Ok(PhysicalGroupBy::new(vec![], vec![], vec![]))
Review Comment:
One of the places that fixes bug 2 that should return nothing for
non-groupby
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
