alamb commented on code in PR #16835: URL: https://github.com/apache/datafusion/pull/16835#discussion_r2233904145
########## datafusion/core/tests/schema_adapter_integration.rs: ########## @@ -0,0 +1,21 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: I think this effectively means we will have a new integration test binary that gets run like ```shell cargo test --test schema_adapter_integration ``` each test binary takes up significant space, and in the past we had problems with the runners disk space filling up IN this case, the new binary takes 188MB on my machine, so it probably would add the same to most CI runs: ```shell (venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ du -s -h target/debug/deps/schema_adapter_integration-2b9fa3c8791a7c77 188M target/debug/deps/schema_adapter_integration-2b9fa3c8791a7c77 ``` Here is a proposed PR to add it to the existing core_integration binary, so it would get run like this: ```shell cargo test --test core_integration -- schema_adapter ``` - https://github.com/kosiew/datafusion/pull/27 And not add a new binary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
