alamb commented on code in PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#discussion_r2231878327
##########
datafusion/core/tests/parquet/schema_adapter.rs:
##########
@@ -370,3 +378,321 @@ async fn
test_custom_schema_adapter_and_custom_expression_adapter() {
];
assert_batches_eq!(expected, &batches);
}
+
+// ----------------------------------------------------------------------
+// Tests migrated from schema_adaptation/schema_adapter_integration_tests.rs
+// ----------------------------------------------------------------------
+
+/// A schema adapter factory that transforms column names to uppercase
+#[derive(Debug, PartialEq)]
+struct UppercaseAdapterFactory {}
+
+impl SchemaAdapterFactory for UppercaseAdapterFactory {
Review Comment:
Moving the tests here sort of implies they are only related to parquet --
don't we apply schema adapter to other formats too?
However, since all the tests use parquet this seems like a good place to put
them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
