findepi commented on PR #17058: URL: https://github.com/apache/datafusion/pull/17058#issuecomment-3178927007
> Fix pushed. It might also be worth thinking about pushing this fix to main, since currently the `SortExec` is also missing there for `string_agg`: I don't think it's imperative to implement the `reverse_expr` for string_agg on the maintenance branch. Is it required here, @berkaysynnada ? I would feel more comfortable approving a smaller PR, especially when it targets a maintenance branch. I am all for improving the state of things on `main`. I would prefer improvements such as adding `reverse_expr` for string_agg are reviewed and merged on `main` first, and then backported to maintenance branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
