findepi commented on code in PR #17058:
URL: https://github.com/apache/datafusion/pull/17058#discussion_r2272648661


##########
datafusion/functions-aggregate/src/string_agg.rs:
##########
@@ -178,6 +178,10 @@ impl AggregateUDFImpl for StringAgg {
         )))
     }
 
+    fn reverse_expr(&self) -> datafusion_expr::ReversedUDAF {

Review Comment:
   Can you please add this on `main` _**first**_?
   This would make it impossible that anyone updating from 49.0.1 to a newer DF 
version experiences a behavioral regression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to