berkaysynnada commented on PR #17058: URL: https://github.com/apache/datafusion/pull/17058#issuecomment-3178977391
@findepi I think it's fine to fix 49.0 with this patch, as it is indeed a bug fix rather than an improvement (if anyone requests it to be fixed). Besides, this should be fixed on main as well in any case. @nuno-faria thank you for spotting this issue. I also recommend adding another slt test to assert the planning result. Otherwise, it’s good to go (after deciding where to land) BTW, how does #16217 affect this? Were you able to see that those queries used `array_agg` before, and after that PR they now use `string_agg`? I’m a bit confused about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
