killme2008 commented on PR #17618: URL: https://github.com/apache/datafusion/pull/17618#issuecomment-3317325010
> I wonder if it is preferable to have a file with only date/timestamp values to test against instead of duplicating `aggregate_test_100.csv` to add only two new columns, or maybe we can just embed those time values directly into the SLT to not need to bump the submodule 🤔 Hi, I’ve considered the same approach. But considering that we’ll have more aggregation function tests around date, time, and timestamp in the future, perhaps having separate test data would be helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
