killme2008 commented on code in PR #17618:
URL: https://github.com/apache/datafusion/pull/17618#discussion_r2366952727
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -169,6 +171,11 @@ where
}
}
+#[derive(Debug, Default)]
+struct NullHLLAccumulator {
+ hll: HyperLogLog<()>,
Review Comment:
Of course we can. I just want to reuse the `default_accumulator_impl` macro
and avoid some boilerplate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
