Jefffrey commented on code in PR #17618:
URL: https://github.com/apache/datafusion/pull/17618#discussion_r2362287634
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -169,6 +171,11 @@ where
}
}
+#[derive(Debug, Default)]
+struct NullHLLAccumulator {
+ hll: HyperLogLog<()>,
Review Comment:
Could we get away with not having this inner `hll` if we aren't going to use
it during updates?
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -4719,9 +4733,7 @@ statement ok
create table t as
select
arrow_cast(column1, 'Date32') as date32,
- -- Workaround https://github.com/apache/arrow-rs/issues/4512 is fixed, can
use this
- -- arrow_cast(column1, 'Date64') as date64,
- arrow_cast(arrow_cast(column1, 'Date32'), 'Date64') as date64,
+ arrow_cast(column1, 'Date64') as date64,
Review Comment:
Nice cleanup 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
