parthchandra commented on code in PR #2258:
URL: https://github.com/apache/datafusion-comet/pull/2258#discussion_r2370491732
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -211,29 +211,80 @@ case class CometShuffleExchangeExec(
}
object CometShuffleExchangeExec extends ShimCometShuffleExchangeExec {
+
def prepareShuffleDependency(
rdd: RDD[ColumnarBatch],
outputAttributes: Seq[Attribute],
outputPartitioning: Partitioning,
serializer: Serializer,
metrics: Map[String, SQLMetric]): ShuffleDependency[Int, ColumnarBatch,
ColumnarBatch] = {
val numParts = rdd.getNumPartitions
+
+ // The code block below is mostly brought over from
+ // ShuffleExchangeExec::prepareShuffleDependency
Review Comment:
It might be non trivial to do so but we could think about this being a plan
we could execute on the native side. Essentially, your original range
partitioner but distributed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
