comphead commented on code in PR #2258:
URL: https://github.com/apache/datafusion-comet/pull/2258#discussion_r2373316456
##########
native/core/src/execution/shuffle/comet_partitioning.rs:
##########
@@ -26,15 +27,15 @@ pub enum CometPartitioning {
Hash(Vec<Arc<dyn PhysicalExpr>>, usize),
/// Allocate rows based on the lexical order of one of more expressions
and the specified number of
Review Comment:
I'm thinking would be that intuitive for the user to have
```
Arc<RowConverter>, Vec<OwnedRow>
```
here? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
