Jefffrey commented on code in PR #17788:
URL: https://github.com/apache/datafusion/pull/17788#discussion_r2382238917
##########
datafusion/core/tests/user_defined/user_defined_window_functions.rs:
##########
@@ -145,22 +145,22 @@ async fn test_udwf_with_alias() {
.await
.unwrap();
- insta::assert_snapshot!(batches_to_string(&actual), @r###"
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- | x | y | val | odd_counter(t.val) PARTITION BY [t.x] ORDER BY [t.y
ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW |
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- | 1 | a | 0 | 1
|
- | 1 | b | 1 | 1
|
- | 1 | c | 2 | 1
|
- | 2 | d | 3 | 2
|
- | 2 | e | 4 | 2
|
- | 2 | f | 5 | 2
|
- | 2 | g | 6 | 2
|
- | 2 | h | 6 | 2
|
- | 2 | i | 6 | 2
|
- | 2 | j | 6 | 2
|
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- "###);
+ insta::assert_snapshot!(batches_to_string(&actual), @r"
+ +---+---+-----+--------------------------+
+ | x | y | val | odd_counter_alias(t.val) |
Review Comment:
I find it inconsistent how having a function alias also removes the
`PARTITION BY...` compared to the non-alias version 🤔
(For reference I do like how it looks without that long column name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
