devampatel03 commented on code in PR #17788:
URL: https://github.com/apache/datafusion/pull/17788#discussion_r2382277644
##########
datafusion/core/tests/user_defined/user_defined_window_functions.rs:
##########
@@ -145,22 +145,22 @@ async fn test_udwf_with_alias() {
.await
.unwrap();
- insta::assert_snapshot!(batches_to_string(&actual), @r###"
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- | x | y | val | odd_counter(t.val) PARTITION BY [t.x] ORDER BY [t.y
ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW |
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- | 1 | a | 0 | 1
|
- | 1 | b | 1 | 1
|
- | 1 | c | 2 | 1
|
- | 2 | d | 3 | 2
|
- | 2 | e | 4 | 2
|
- | 2 | f | 5 | 2
|
- | 2 | g | 6 | 2
|
- | 2 | h | 6 | 2
|
- | 2 | i | 6 | 2
|
- | 2 | j | 6 | 2
|
-
+---+---+-----+-----------------------------------------------------------------------------------------------------------------------+
- "###);
+ insta::assert_snapshot!(batches_to_string(&actual), @r"
+ +---+---+-----+--------------------------+
+ | x | y | val | odd_counter_alias(t.val) |
Review Comment:
@Jefffrey,
You've pointed out the exact inconsistency that I also came across in my
last PR!
I had a discussion about this with @alamb (you can see the conversation
here:
https://github.com/apache/datafusion/issues/17469#issuecomment-3334891167), and
we agreed the best plan was to fix the alias naming first in this PR, and then
create a new issue for normalizing output column names of window functions.
I've already created that follow-up issue at #17790.
So, this PR just brings the alias behavior in line with the other function
types, and we can address the rest of the cleanup in the new issue. Thanks for
the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
