milenkovicm commented on PR #18192: URL: https://github.com/apache/datafusion/pull/18192#issuecomment-3445960495
> > I'm not clear on what the pros/cons of &TaskContext vs. &dyn FunctionRegistry are. I fear that some folks doing distributed (cc @gabotechs) want "more" > > Note that having a `DecodeContext` or a `impl Into<DecodeContext<'a>>` for tracking ids of expressions derived from their pointer addresses still leaves part of the challenge unsolved, as we'll still not be able use that for communicating dynamic filter updates over the wire in a distributed context as is. > > It might be worth to at least have a plan on how to do that end to end before committing to introducing an API change that might need to get revisited for having a full solution. If we're talking about adding `impl Into<DecodeContext<'a>>` I believe it makes sense to add `&dyn DecodeContext` better, with non caching implementation as the default. At the moment caching implementation **may have** benefits in very specific case, so for generic case having cache disabled does look like the best approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
