milenkovicm commented on PR #18192: URL: https://github.com/apache/datafusion/pull/18192#issuecomment-3446701092
> > If we want to proceed in this direction, making cache disabled by default would make sense, as the benefits of having it on are not really obvious and very use case specific. > > Isn't there a benefit for all users of reducing blowup of duplicate expressions? If duplicate expressions aren't a problem we wouldn't be Arcing them in the first place. > > The cost is miniscule: a hashmap of integers and pointers. Most users do not have this problem to start with. It's not issue with performance overhead issue is with user generated ids, and subtitle bugs it can bring. Also I believe it's trivial to have two implementation one which will cache other which won't and change it as needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
