milenkovicm commented on code in PR #18192:
URL: https://github.com/apache/datafusion/pull/18192#discussion_r2462926232
##########
datafusion/proto/src/bytes/mod.rs:
##########
@@ -333,5 +334,6 @@ pub fn physical_plan_from_bytes_with_extension_codec(
) -> Result<Arc<dyn ExecutionPlan>> {
let protobuf = protobuf::PhysicalPlanNode::decode(bytes)
.map_err(|e| plan_datafusion_err!("Error decoding expr as protobuf:
{e}"))?;
- protobuf.try_into_physical_plan(ctx, extension_codec)
+ let decode_ctx = DecodeContext::new(ctx);
Review Comment:
should decode_ctx be method parameter rather than created here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
