rluvaton commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469892421
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -845,6 +859,7 @@ impl GroupedHashAggregateStream {
evaluate_optional(&self.filter_expressions, &batch)?
};
+ let aggregation_timer = self.group_by_metrics.aggregation_time.timer();
Review Comment:
the loop also contain building and searching the hash table
`self.group_values.intern` which can be expensive (e.g. when `GroupValuesRows`
is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
