EmilyMatt commented on code in PR #18325: URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469869413
########## datafusion/physical-plan/src/aggregates/group_values/metrics.rs: ########## @@ -0,0 +1,204 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Metrics for the various group-by implementations. + +use crate::metrics::{ExecutionPlanMetricsSet, MetricBuilder, Time}; + +pub struct GroupByMetrics { + pub aggregate_arguments_time: Time, + pub aggregation_time: Time, + pub emitting_time: Time, Review Comment: Same as previous comments, I think using clocks here is going to start encumbering the system ########## datafusion/physical-plan/src/aggregates/topk_stream.rs: ########## @@ -111,10 +119,13 @@ impl Stream for GroupedTopKAggregateStream { mut self: Pin<&mut Self>, cx: &mut Context<'_>, ) -> Poll<Option<Self::Item>> { + let elapsed_compute = self.baseline_metrics.elapsed_compute().clone(); while let Poll::Ready(res) = self.input.poll_next_unpin(cx) { match res { // got a batch, convert to rows and append to our TreeMap Some(Ok(batch)) => { + let _timer = elapsed_compute.timer(); Review Comment: Yeah absolutely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
