EmilyMatt commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469879061
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1359,12 +1360,17 @@ fn evaluate(
.collect()
}
-/// Evaluates expressions against a record batch.
-pub fn evaluate_many(
Review Comment:
I think this is a sure way to end up with lots of dead code because "someone
surely uses it", instead, it was simply a mistake to have such a generic
utility in this file made public, and the earlier it is fixed the less people
are affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
