zhuqi-lucas commented on code in PR #18492:
URL: https://github.com/apache/datafusion/pull/18492#discussion_r2493653758


##########
.github/workflows/rust.yml:
##########
@@ -475,7 +475,7 @@ jobs:
           export RUST_MIN_STACK=20971520
           export TPCH_DATA=`realpath 
datafusion/sqllogictest/test_files/tpch/data`
           cargo test plan_q --package datafusion-benchmarks --profile ci 
--features=ci -- --test-threads=1
-          INCLUDE_TPCH=true cargo test --features backtrace --profile ci 
--package datafusion-sqllogictest --test sqllogictests
+          INCLUDE_TPCH=true cargo test --features backtrace, 
parquet_encryption --profile ci --package datafusion-sqllogictest --test 
sqllogictests

Review Comment:
   > Do we need to do this fix in other places too? e.g.
   
   Good catch, the extended test should be consistent.
   
   > If this command is reused, I think it's better to put them inside a .sh 
script.
   
   This is a good future improvement for common logic.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to