zhuqi-lucas commented on code in PR #18492:
URL: https://github.com/apache/datafusion/pull/18492#discussion_r2494805879
##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -43,7 +43,7 @@ bigdecimal = { workspace = true }
bytes = { workspace = true, optional = true }
chrono = { workspace = true, optional = true }
clap = { version = "4.5.50", features = ["derive", "env"] }
-datafusion = { workspace = true, default-features = true, features = ["avro",
"parquet_encryption"] }
+datafusion = { workspace = true, default-features = true, features = ["avro"] }
Review Comment:
Good point @alamb , i think default features are ok, i just tried to set
false here, the sqllogictest will fail in my local test.
And here we remove here for parquet_encryption because it removed from
datafusion default, also i think the encryption should be always optional
instead of the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
