alamb commented on code in PR #18492:
URL: https://github.com/apache/datafusion/pull/18492#discussion_r2494547164
##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -43,7 +43,7 @@ bigdecimal = { workspace = true }
bytes = { workspace = true, optional = true }
chrono = { workspace = true, optional = true }
clap = { version = "4.5.50", features = ["derive", "env"] }
-datafusion = { workspace = true, default-features = true, features = ["avro",
"parquet_encryption"] }
+datafusion = { workspace = true, default-features = true, features = ["avro"] }
Review Comment:
Yeah, I was suggesting turning off the default features.
I think given this says default-features=true, that means that anyone who
uses datafusion-sqllogictest will get all default features, and there will not
be any way to turn it off
##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -43,7 +43,7 @@ bigdecimal = { workspace = true }
bytes = { workspace = true, optional = true }
chrono = { workspace = true, optional = true }
clap = { version = "4.5.50", features = ["derive", "env"] }
-datafusion = { workspace = true, default-features = true, features = ["avro",
"parquet_encryption"] }
+datafusion = { workspace = true, default-features = true, features = ["avro"] }
Review Comment:
Yeah, I was suggesting turning off the default features.
I think given this says default-features=true, that means that anyone who
uses datafusion-sqllogictest will get all default features, and there will not
be any way to turn the default features off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
