vegarsti opened a new pull request, #18500:
URL: https://github.com/apache/datafusion/pull/18500
## Rationale for this change
Noticed while doing #18424 that the list types `List` and `FixedSizeList`
uses `MutableData` to build the reverse array. That turns out to be a lot
faster. Confirm by running the benchmark #18425:
```
# cargo bench --bench array_reverse
Compiling datafusion-functions-nested v50.3.0
(/Users/vegard/dev/datafusion/datafusion/functions-nested)
Finished `bench` profile [optimized] target(s) in 42.94s
Running benches/array_reverse.rs
(target/release/deps/array_reverse-2c473eed34a53d0a)
Gnuplot not found, using plotters backend
array_reverse_list time: [65.812 µs 65.995 µs 66.268 µs]
change: [−84.353% −84.303% −84.247%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
array_reverse_fixed_size_list
time: [167.04 µs 167.64 µs 168.21 µs]
change: [−61.541% −61.375% −61.213%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
```
## Are these changes tested?
Covered by existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
