Jefffrey commented on PR #18500: URL: https://github.com/apache/datafusion/pull/18500#issuecomment-3500279387
> > A note regarding benchmarks, we might need to add a bit of randomness + null spread for more accurate benchmarking perhaps. As they currently are I believe they always create arrays of fixed offsets for every child list. > > I've started on this but didn't finish -- I couldn't figure out how to properly set a random seed. Any pointers? 🤔 I don't know exactly what you mean, but maybe you can use the map benchmark as a reference? https://github.com/apache/datafusion/blob/7591919be7e6582ed7f6a8d0b033f7a0a8ad60f7/datafusion/functions-nested/benches/map.rs#L57-L59 They don't seem to set the seed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
