vegarsti commented on code in PR #18500:
URL: https://github.com/apache/datafusion/pull/18500#discussion_r2495679081
##########
datafusion/functions-nested/src/reverse.rs:
##########
@@ -171,18 +168,34 @@ fn general_array_reverse<O: OffsetSizeTrait>(
let mut index = end - O::one();
while index >= start {
- mutable.extend(0, index.to_usize().unwrap(),
index.to_usize().unwrap() + 1);
+ indices.push(index);
index = index - O::one();
}
let size = end - start;
offsets.push(offsets[row_index] + size);
}
- let data = mutable.freeze();
+ // Materialize values from underlying array with take
+ let indices_array: ArrayRef = if O::IS_LARGE {
+ Arc::new(UInt64Array::from(
+ indices
+ .iter()
+ .map(|i| i.as_usize() as u64)
+ .collect::<Vec<_>>(),
+ ))
+ } else {
+ Arc::new(UInt32Array::from(
+ indices
+ .iter()
+ .map(|i| i.as_usize() as u32)
+ .collect::<Vec<_>>(),
+ ))
+ };
Review Comment:
This is duplicated for `ListView`. I figured twice was not enough to extract
to a function, but if we find a nicer way to do it, we can improve both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
