2010YOUY01 commented on PR #18520: URL: https://github.com/apache/datafusion/pull/18520#issuecomment-3500542386
> Yes, I ran cargo test --package datafusion-expr and all but one passed (based on my observations, it seems to not be related to my changes). The failed test is: test expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias ... FAILED Thank you for working on it! I think the failure is due to the public API change. I have updated the write up https://github.com/apache/datafusion/issues/18503's instruction section, you can find details there. BTW I suggest to turn off the lint for test modules (see above link) and start over, it seems there are only around 2 changes required for this crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
