Jefffrey commented on code in PR #18520:
URL: https://github.com/apache/datafusion/pull/18520#discussion_r2501492085
##########
datafusion/expr/Cargo.toml:
##########
@@ -31,8 +31,12 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
-[lints]
-workspace = true
+[lints] # Overrides / extends workspace.lints
Review Comment:
I think this actually loses the override, so we don't get those workspace
lints anymore
##########
datafusion/expr/src/literal.rs:
##########
@@ -21,11 +21,11 @@ use crate::Expr;
use datafusion_common::{metadata::FieldMetadata, ScalarValue};
/// Create a literal expression
-pub fn lit<T: Literal>(n: T) -> Expr {
+pub fn lit<T: Literal>(n: &T) -> Expr {
Review Comment:
These `lit` changes would be too breaking, I think we shouldn't do this and
just place a clippy allow for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
