Jefffrey commented on code in PR #18520:
URL: https://github.com/apache/datafusion/pull/18520#discussion_r2501795246
##########
datafusion/expr/Cargo.toml:
##########
@@ -31,8 +31,12 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
-[lints]
-workspace = true
+[lints] # Overrides / extends workspace.lints
Review Comment:
> but this is fine now since there are no lints configuration in the top
level `Cargo.toml` now
Now as of main or as of some other PR?
I tested the inheritance and it works, but with this change it removes the
workspace inherited lints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
