2010YOUY01 commented on code in PR #18520:
URL: https://github.com/apache/datafusion/pull/18520#discussion_r2501570684
##########
datafusion/expr/src/literal.rs:
##########
@@ -21,11 +21,11 @@ use crate::Expr;
use datafusion_common::{metadata::FieldMetadata, ScalarValue};
/// Create a literal expression
-pub fn lit<T: Literal>(n: T) -> Expr {
+pub fn lit<T: Literal>(n: &T) -> Expr {
Review Comment:
I think we should avoid changing public APIs, and suppress them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
