pepijnve commented on code in PR #18821: URL: https://github.com/apache/datafusion/pull/18821#discussion_r2542501127
########## datafusion/optimizer/src/simplify_expressions/mod.rs: ########## @@ -35,4 +34,4 @@ pub use simplify_exprs::*; pub use simplify_predicates::simplify_predicates; // Export for test in datafusion/core/tests/optimizer_integration.rs -pub use guarantees::GuaranteeRewriter; +pub use datafusion_expr::expr_rewriter::GuaranteeRewriter; Review Comment: If this was only exported for testing purposes, is it really necessary to keep it? Once it's out there, there's no taking back of course, so perhaps best to be conservative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
