alamb commented on code in PR #18821:
URL: https://github.com/apache/datafusion/pull/18821#discussion_r2542626934
##########
datafusion/expr/src/expr_rewriter/guarantees.rs:
##########
@@ -458,7 +527,9 @@ mod tests {
.collect(),
*negated,
);
- let output = expr.clone().rewrite(&mut rewriter).data().unwrap();
+ let output = rewrite_with_guarantees(expr.clone(),
guarantees.iter())
+ .data()
+ .unwrap();
let expected_list = expected_list
.iter()
.map(|v| lit(ScalarValue::Int32(Some(*v))))
Review Comment:
Did you want to add a test for the newly fixed case too?
As in I don't see any tests for the bug fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
