alamb commented on code in PR #18821: URL: https://github.com/apache/datafusion/pull/18821#discussion_r2542532665
########## datafusion/optimizer/src/simplify_expressions/mod.rs: ########## @@ -35,4 +34,4 @@ pub use simplify_exprs::*; pub use simplify_predicates::simplify_predicates; // Export for test in datafusion/core/tests/optimizer_integration.rs -pub use guarantees::GuaranteeRewriter; +pub use datafusion_expr::expr_rewriter::GuaranteeRewriter; Review Comment: I think we should be conservative (keep it) unless there is a good reason not to My rationale is that it is really annoying as a downstream user if I have to change my code and get nothing from needing to do so (other than the upstream crate maintainers now feel their code is cleaner) 🤷 -- not a hard and fast rule, but one I think has served us well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
