kumarUjjawal commented on code in PR #19931:
URL: https://github.com/apache/datafusion/pull/19931#discussion_r2726452746
##########
datafusion-examples/examples/data_io/parquet_encrypted.rs:
##########
@@ -55,7 +55,7 @@ pub async fn parquet_encrypted() ->
datafusion::common::Result<()> {
// Create a temporary file location for the encrypted parquet file
let tmp_source = TempDir::new()?;
- let tempfile = tmp_source.path().join("cars_encrypted");
+ let tempfile = tmp_source.path().join("cars_encrypted.parquet");
Review Comment:
Before this PR, `with_single_file_output(true)` was silently ignored for
paths without extensions it would create a directory `cars_encrypted/` with
parquet files inside. The `read_parquet()` call then found these files in the
directory. After this PR, `with_single_file_output(true)` is correctly
respected, creating a single file at the exact path `cars_encrypted` . However,
`read_parquet()` with default options expects a `.parquet` extension and fails
validation. Adding .parquet to the filename fixes this and makes the example
explicit about the expected file format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
