kumarUjjawal commented on code in PR #19931:
URL: https://github.com/apache/datafusion/pull/19931#discussion_r2726486597
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -549,8 +549,30 @@ impl DefaultPhysicalPlanner {
}
};
+ // Parse single_file_output option if explicitly set
+ let file_output_mode = match source_option_tuples
Review Comment:
I kept `with_single_file_output(bool)` in DataFrameWriteOptions for backward
compatibility, it's the existing public API. Internally, I changed the field to
Option<bool> so we can distinguish "not set" from "explicitly set to false".
The conversion to FileOutputMode happens in the physical planner. Adding
`with_file_output_mode(FileOutputMode)` would expand the API surface; are you
okay with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
