JosiahWI commented on code in PR #11668:
URL: https://github.com/apache/trafficserver/pull/11668#discussion_r1716774126
##########
plugins/experimental/stek_share/log_store.cc:
##########
@@ -90,7 +91,7 @@ STEKShareLogStore::write_at(uint64_t index,
nuraft::ptr<nuraft::log_entry> &entr
while (itr != logs_.end()) {
itr = logs_.erase(itr);
}
- logs_[index] = clone;
+ logs_[index] = std::move(clone);
Review Comment:
The reason this uses a temporary is to reduce the amount of work done while
holding the logs lock. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
