JosiahWI commented on code in PR #11668:
URL: https://github.com/apache/trafficserver/pull/11668#discussion_r1716961065
##########
plugins/statichit/statichit.cc:
##########
@@ -71,7 +73,7 @@ struct StaticHitConfig {
base_path = std::filesystem::weakly_canonical(base_path);
if (std::filesystem::is_directory(base_path)) {
- dirPath = base_path;
+ dirPath = std::move(base_path);
Review Comment:
Weirdly, Coverity does not have a CID for it. Maybe it has to do with the
difference in types: `std::filesystem::path` vs `std::string`. I changed it
anyway for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]