JosiahWI commented on code in PR #11668:
URL: https://github.com/apache/trafficserver/pull/11668#discussion_r1716793252
##########
src/traffic_layout/engine.cc:
##########
@@ -362,7 +363,7 @@ LayoutEngine::remove_runroot()
return;
}
- std::string clean_root = path;
+ std::string clean_root = std::move(path);
Review Comment:
I think the intent was to distinguish whether the string has been sanitized
or not, even though it's the same string object being modified. I think
`clean_root` should be a reference - there's no need to copy or move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
