cmcfarlen commented on code in PR #11668:
URL: https://github.com/apache/trafficserver/pull/11668#discussion_r1717089569
##########
plugins/experimental/stek_share/log_store.cc:
##########
@@ -83,6 +83,7 @@ STEKShareLogStore::append(nuraft::ptr<nuraft::log_entry>
&entry)
void
STEKShareLogStore::write_at(uint64_t index, nuraft::ptr<nuraft::log_entry>
&entry)
{
+ // We prepare what we can taking the logs lock to minimize time holding it.
Review Comment:
Missing the word `before` perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
