http://gwt-code-reviews.appspot.com/154810/diff/63002/70001 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right):
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode86 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:86: writer.getOracle().findType(Grid.class.getName()), "0", "0"); This line serves no purpose that I can see. http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode130 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:130: writer.die("Grid's <g:row> tag in %s may only contain %s or %s element.", No need for < here, and "g:" shouldn't be hard coded http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode149 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:149: throws UnableToCompleteException { You're not enforcing that the child elements have the same prefix as the parent. (Note that you should not hardcode "g:", just make sure that they all have the same value for XmlElement#getPrefix.) http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode152 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:152: String tagName = child.getLocalName(); Compare prefix too http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode154 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:154: writer.die("Invalid Grid child element: " + tagName); "%1$s:Grid elements must contain only %1$s:%2$s children, found %3$s:%4$s", elem.getPrefix(), ROW_TAG, child.getPrefix(), tagName http://gwt-code-reviews.appspot.com/154810/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
