http://gwt-code-reviews.appspot.com/1113801/diff/1/4 File dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java (right):
http://gwt-code-reviews.appspot.com/1113801/diff/1/4#newcode23 dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java:23: throws NotFoundException; The return type is tightened on this version. http://gwt-code-reviews.appspot.com/1113801/diff/1/10 File dev/core/src/com/google/gwt/core/ext/typeinfo/JField.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/10#newcode30 dev/core/src/com/google/gwt/core/ext/typeinfo/JField.java:30: boolean isDefaultAccess(); On 2010/11/16 19:54:50, zundel wrote:
isDefaultAccess(), isPrivate(), isProtected(), isPublic(), isStatic()
are
defined in more than one class. Deserves to be consolidated under new HasAccess/HasProtection interface?
Perhaps! I figured we could have an API change discussion after I land the refactor. http://gwt-code-reviews.appspot.com/1113801/diff/1/12 File dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/12#newcode36 dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java:36: String toString(); Good call. http://gwt-code-reviews.appspot.com/1113801/diff/1/13 File dev/core/src/com/google/gwt/core/ext/typeinfo/JPackage.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/13#newcode25 dev/core/src/com/google/gwt/core/ext/typeinfo/JPackage.java:25: JClassType findType(String[] typeName); I haven't a clue. I'll look into it, or add a todo. http://gwt-code-reviews.appspot.com/1113801/diff/1/15 File dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/15#newcode22 dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java:22: public interface JParameterizedType extends JClassType { In my version, JMaybeParameterizedType has been moved to com.google.gwt.dev.javac.typemodel. http://gwt-code-reviews.appspot.com/1113801/diff/1/16 File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/16#newcode34 dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:34: public enum JPrimitiveType implements JType { The API design pretty much forbids that idea without breaking existing code. Since it's a set of static singleton field refs, there can really only be one implementation. http://gwt-code-reviews.appspot.com/1113801/diff/1/16#newcode40 dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:40: "void", "Void", DESC_VOID, "null"); Thanks! Much better. http://gwt-code-reviews.appspot.com/1113801/diff/1/28 File dev/core/src/com/google/gwt/dev/javac/typemodel/JAbstractMethod.java (right): http://gwt-code-reviews.appspot.com/1113801/diff/1/28#newcode30 dev/core/src/com/google/gwt/dev/javac/typemodel/JAbstractMethod.java:30: com.google.gwt.core.ext.typeinfo.JAbstractMethod { Agreed; unfortunately the jitter would have been even more horrific. I figured I could land this as-is, and then we could decide whether to rename the impl classes as a follow-on change. http://gwt-code-reviews.appspot.com/1113801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
