just some nits and a possible TODO

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003#newcode2
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:2:
* Copyright 2010 Google Inc.
welcome to 2011

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40008
File dev/core/src/com/google/gwt/dev/javac/typemodel/JRealClassType.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40008#newcode108
dev/core/src/com/google/gwt/dev/javac/typemodel/JRealClassType.java:108:
this.byteCode = byteCode;
I was just thinking - queuing up a task here to compute the hash is a
function it might be nice to offload some work to a thread.  Then, on
refresh, the old version would always be computed.  This might give us
better startup performance on muliticore boxes too.

Just a thought - add a TODO if you think it would be worthwhile to look
into.

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40013
File
user/src/com/google/gwt/resources/ext/SupportsGeneratorResultCaching.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40013#newcode2
user/src/com/google/gwt/resources/ext/SupportsGeneratorResultCaching.java:2:
* Copyright 2010 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1236801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to