http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001 File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28 dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28: void addByteCode(byte[] byteCode); On 2011/01/25 00:48:19, jbrosenberg wrote:
On 2011/01/24 19:14:07, tobyr wrote: > Why is this method in the public interface? Can we just remove it
and leave
the > implementation in typemodel.JRealClassType?
Well, I thought about doing that, but then we'd lose the benefits of
the
interface layer. The generator calling getTypeStrongHash shouldn't
need to know
the specific implementation for JRealClassType (and of type oracle).
The
generators refer to the interface versions of all the type oracle and
class type
apis, and so this was in keeping with that.
Once we get the changes into TypeOracleMediator to be able to more
specifically
check type structure/version, we can add a capability interface (as
Bob
suggests), e.g. HasTypeStructureSignature.
Ok, I see the light now....done http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
