Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
......................................................................
Patch Set 2:
(3 comments)
Daniel, can you also respond to other concerns?
It is a good idea to respond every comment sometimes just with "Done" so
that it will be clear if you have a missed any comment or not :)
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 306: * Clear the rootPanel. If clearDom is true, then also remove
any DOM
When describing a method it is better to use Clears vs Clear.
"then also" has double space.
Line 309: * By default {@link #clear()} will only remove children that
are GWT widgets.
<p> otherwise it will not be a new paragraph in generated javadoc.
Line 324: DOM.removeChild(containerElement, child);
This will also remove text nodes. I was also wondering innerHTML but
according to a jsperf comparison it is much slower:
http://jsperf.com/innerhtml-vs-removechild
--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
