Thomas Broyer has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
......................................................................


Patch Set 2:

(1 comment)

....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 324:         DOM.removeChild(containerElement, child);
Thanks for the link Goktug. This IMO aligns with Brian's proposal to move it within Element (though Node would be even better), where it could be done with JSNI, and possibly use deferred-binding if there's a need for some browser-specific implementation.

BTW, the latest revision of this test, published 3 weeks ago, is at http://jsperf.com/innerhtml-vs-removechild/26


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to