Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 2:
(6 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 29: * methods. When added to a panel, a composite behaves exactly as
if the widget
Done
Line 37: * @param <T> type of the widget wrapped
Updated docs.
@tbroyer: it is better to defer removal of setWidget to a separate patch.
Line 127: public T getDelegate() {
Opps, good catch! I wasn't intending to make it public.
For the final part, I will keep it non-final due to the
non-final 'getWidget' pair.
Line 148: *
Done
Line 151: * will be delegated (e.g. HasWidget#add)
Done
....................................................
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 52: HasAllMouseHandlers, HasAllGestureHandlers,
HasAllTouchHandlers {
Done. It looks like I also missed HasEnabled which I added now.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
