John Ahlroos has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 2:
I am not really keen on introducing another JSO for the subpixel variants.
As Jens points out getting the subpixel values becomes very tiresome in the
long run when you always have to make that extra method call to get the
subpixel JSO or then manually manually make the cast.
If we go the route with "ImageElement.toSubpixelImageElement()"-type
casting helpers then wouldn't it also mean all XYZElement classes will need
to add the XYZElement.toSubpixelXYZElement() method? Also, should the
returned class be SubpixelXYZElement or just SubpixelElement? We have the
NativeEvent class which needs the same kind of treatment, should there also
then be a SubpixelNativeEvent? And how about the DOMImpl's?
With considering all of this I have to say I am still in favour of just
adding the subpixel variants (this CL) and keeping the method naming
consistent across Element/NativeEvent/DOMImpl.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
