Brian Slesinsky has posted comments on this change.

Change subject: Ensures integer pixel values and adds getters for subpixel values
......................................................................


Patch Set 2:

[4] is shorter than [1]. The only question is how common it is. I haven't worked with subpixel values myself, so I don't know whether we're talking about a rare corner case or something people will use all the time.

It seems like a pixel (even a virtual one) is a small enough unit that we'd rarely need to work with anything smaller. But then again I'm not a designer.

So, any ideas as to what we're going to use this API for? I hate to add a lot of clutter if it won't be used much.

--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to