[
https://issues.apache.org/jira/browse/HADOOP-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498807
]
Owen O'Malley commented on HADOOP-1425:
---------------------------------------
The problem with ToolBase in my opinion is it is the wrong abstraction.
ToolBase doesn't really provide any useful ones. Using mixins (acquiring
functionality via inheritance) is usually problematic and especially in Java
where you can only have one parent class. This can been seen by people getting
confused about where the various mains are and how they are being called. Every
time, I look at one of those ToolBase-children, I need to untangle where the
run() method is versus doMain() and which is which. It would be much better if
was just a library that used cli or cli2 that let the application add
parameters, but defined a "standard hadoop" set of options. The only downside
to that approach is that it is nice to be able to handle commonexceptions in
the doMain.
> Rework the various programs in 'examples' to extend ToolBase
> -------------------------------------------------------------
>
> Key: HADOOP-1425
> URL: https://issues.apache.org/jira/browse/HADOOP-1425
> Project: Hadoop
> Issue Type: Improvement
> Components: examples
> Reporter: Arun C Murthy
> Assigned To: Enis Soztutar
> Priority: Minor
> Fix For: 0.14.0
>
>
> Ensuring all 'examples' extend ToolBase will make it easy to tweak various
> config params (via -D switches for e.g.) while running the programs...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
