On Wed, Mar 03, 2010 at 01:02:16AM +0100, Krzysztof Ol??dzki wrote: > On 2010-03-03 00:47, Willy Tarreau wrote: > >On Wed, Mar 03, 2010 at 12:39:48AM +0100, Willy Tarreau wrote: > >>>Finally, encryption was only tested on Linux and FreeBSD so it could be > >>>nice to verify if it works on Solaris in the same way (with -lcrypt) and > >>>to add USE_LIBCRYPT for "ifeq ($(TARGET),solaris)". > >> > >>OK I'm testing it now then and will keep you informed. > > > >it builds with the same warning as we had on linux, despite the > >man not mentioning anything specific. > > :( Did you include unistd.h? If so, could you try defining _XOPEN_SOURCE > to 600? > > >However, on solaris, crypt() > >is defined in crypt.h, which I also have here on linux and which > >is in some of my old programs which made use of crypt(). > > Blah... This shows why configure is so popular... :|
Popular... among developers because it saves them from searching. It's commonly hated among users because it works 50% of the time, and the other 50% it's a hell to debug or to find a way to force your options. > >Ross, it would be nice if you could check on FreeBSD if we have > >crypt.h available. Probably that we should make use of it by > >default and not rely on the "standard" includes which are only > >there for compatibility with specific programs which define > >_XOPEN_SOURCE. > > I have several FreeBSD servers - 4.x, 5.x, 6.x, 7.x, and 8.x. None of > them have crypt.h. :( OK thanks for checking. So maybe we could define a NEED_CRYPT_H macro in the makefile for linux and solaris and not for other OSes right now. Regards, Willy
